Merge pull request #5688 from marmelab/empty-with-no-create

Fix Empty Component Display When No Create

Author: fzaninotto

packages/ra-core/src/dataProvider/useQueryWithStore.ts

@@ -158,6 +158,7 @@ const useQueryWithStore = <State extends ReduxState = ReduxState>(
                     data,
                     total,
                     loaded: true,
+                    loading: false,
                 }));
             }
         }

packages/ra-ui-materialui/src/list/Empty.tsx

@@ -33,7 +33,7 @@ const useStyles = makeStyles(
 );
 
 const Empty: FC<EmptyProps> = props => {
-    const { basePath } = useListContext(props);
+    const { basePath, hasCreate } = useListContext(props);
     const resource = useResourceContext(props);
     const classes = useStyles(props);
     const translate = useTranslate();
@@ -61,15 +61,19 @@ const Empty: FC<EmptyProps> = props => {
                         _: emptyMessage,
                     })}
                 </Typography>
-                <Typography variant="body1">
-                    {translate(`resources.${resource}.invite`, {
-                        _: inviteMessage,
-                    })}
-                </Typography>
-            </div>
-            <div className={classes.toolbar}>
-                <CreateButton variant="contained" basePath={basePath} />
+                {hasCreate && (
+                    <Typography variant="body1">
+                        {translate(`resources.${resource}.invite`, {
+                            _: inviteMessage,
+                        })}
+                    </Typography>
+                )}
             </div>
+            {hasCreate && (
+                <div className={classes.toolbar}>
+                    <CreateButton variant="contained" basePath={basePath} />
+                </div>
+            )}
         </>
     );
 };

packages/ra-ui-materialui/src/list/ListView.tsx

@@ -46,7 +46,6 @@ export const ListView = (props: ListViewProps) => {
         total,
         loaded,
         loading,
-        hasCreate,
         filterValues,
         selectedIds,
     } = listContext;
@@ -88,11 +87,7 @@ export const ListView = (props: ListViewProps) => {
     );
 
     const shouldRenderEmptyPage =
-        hasCreate &&
-        loaded &&
-        !loading &&
-        total === 0 &&
-        !Object.keys(filterValues).length;
+        loaded && !loading && total === 0 && !Object.keys(filterValues).length;
 
     return (
         <div