Merge pull request #6256 from marmelab/fix-use-suggestions-with-selected-item-array

Fix useSugggestion tries to match selected items

Author: fzaninotto

packages/ra-core/src/form/useSuggestions.spec.ts

@@ -110,6 +110,35 @@ describe('getSuggestions', () => {
         ]);
     });
 
+    it('should not add createSuggestion if allowCreate is true and the current filter matches exactly the selected item', () => {
+        expect(
+            getSuggestions({
+                ...defaultOptions,
+                selectedItem: { id: 1, value: 'one' },
+                allowCreate: true,
+            })('one')
+        ).toEqual([
+            { id: 2, value: 'two' },
+            { id: 3, value: 'three' },
+        ]);
+    });
+
+    it('should add createSuggestion if allowCreate is true and selectedItem is an array', () => {
+        expect(
+            getSuggestions({
+                ...defaultOptions,
+                selectedItem: [
+                    { id: 1, value: 'one' },
+                    { id: 2, value: 'two' },
+                ],
+                allowCreate: true,
+            })('')
+        ).toEqual([
+            { id: 3, value: 'three' },
+            { id: '@@create', value: 'ra.action.create' },
+        ]);
+    });
+
     it('should limit the number of choices', () => {
         expect(
             getSuggestions({

packages/ra-core/src/form/useSuggestions.ts

@@ -226,11 +226,13 @@ export const getSuggestionsFactory = ({
         matchSuggestion(filter, suggestion, true)
     );
 
-    const filterIsSelectedItem = !!selectedItem
-        ? matchSuggestion(filter, selectedItem, true)
-        : false;
-
     if (allowCreate) {
+        const filterIsSelectedItem =
+            // If the selectedItem is an array (for example AutocompleteArrayInput)
+            // we should't try to match
+            !!selectedItem && !Array.isArray(selectedItem)
+                ? matchSuggestion(filter, selectedItem, true)
+                : false;
         if (!hasExactMatch && !filterIsSelectedItem) {
             suggestions.push(
                 getSuggestion({