Skip to content

Commit 98babf8

Browse files
authored
Merge pull request #6484 from marmelab/concise-translatable-input
Reduce TranslatableInputs margin
2 parents 19dc5b9 + 4519b74 commit 98babf8

File tree

4 files changed

+22
-3
lines changed

4 files changed

+22
-3
lines changed

packages/ra-ui-materialui/src/input/TranslatableInputs.tsx

+6-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {
44
TranslatableContextProvider,
55
useTranslatable,
66
UseTranslatableOptions,
7+
InputProps,
78
} from 'ra-core';
89
import { TranslatableInputsTabs } from './TranslatableInputsTabs';
910
import { TranslatableInputsTabContent } from './TranslatableInputsTabContent';
@@ -69,6 +70,8 @@ export const TranslatableInputs = (props: TranslatableProps): ReactElement => {
6970
groupKey = '',
7071
selector = <TranslatableInputsTabs groupKey={groupKey} />,
7172
children,
73+
variant,
74+
margin,
7275
} = props;
7376
const context = useTranslatable({ defaultLocale, locales });
7477
const classes = useStyles(props);
@@ -82,6 +85,8 @@ export const TranslatableInputs = (props: TranslatableProps): ReactElement => {
8285
key={locale}
8386
locale={locale}
8487
groupKey={groupKey}
88+
variant={variant}
89+
margin={margin}
8590
>
8691
{children}
8792
</TranslatableInputsTabContent>
@@ -91,7 +96,7 @@ export const TranslatableInputs = (props: TranslatableProps): ReactElement => {
9196
);
9297
};
9398

94-
export interface TranslatableProps extends UseTranslatableOptions {
99+
export interface TranslatableProps extends UseTranslatableOptions, InputProps {
95100
selector?: ReactElement;
96101
children: ReactNode;
97102
groupKey?: string;

packages/ra-ui-materialui/src/input/TranslatableInputsTab.tsx

+8-1
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,21 @@ export const TranslatableInputsTab = (
2424
label={translate(`ra.locales.${locale}`, {
2525
_: capitalize(locale),
2626
})}
27-
className={invalid && touched ? classes.error : undefined}
27+
className={`${classes.root} ${
28+
invalid && touched ? classes.error : ''
29+
}`}
2830
{...rest}
2931
/>
3032
);
3133
};
3234

3335
const useStyles = makeStyles(
3436
theme => ({
37+
root: {
38+
fontSize: '0.8em',
39+
minHeight: theme.spacing(3),
40+
minWidth: theme.spacing(6),
41+
},
3542
error: { color: theme.palette.error.main },
3643
}),
3744
{ name: 'RaTranslatableInputsTab' }

packages/ra-ui-materialui/src/input/TranslatableInputsTabContent.tsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,10 @@ const useStyles = makeStyles(
9090
theme => ({
9191
root: {
9292
flexGrow: 1,
93-
padding: theme.spacing(2),
93+
paddingLeft: theme.spacing(2),
94+
paddingRight: theme.spacing(2),
95+
paddingTop: theme.spacing(1),
96+
paddingBottom: theme.spacing(1),
9497
borderRadius: 0,
9598
borderBottomLeftRadius: theme.shape.borderRadius,
9699
borderBottomRightRadius: theme.shape.borderRadius,

packages/ra-ui-materialui/src/input/TranslatableInputsTabs.tsx

+4
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ export const TranslatableInputsTabs = (
2828
onChange={handleChange}
2929
indicatorColor="primary"
3030
textColor="primary"
31+
className={classes.tabs}
3132
{...tabsProps}
3233
>
3334
{locales.map(locale => (
@@ -57,6 +58,9 @@ const useStyles = makeStyles(
5758
borderTopRightRadius: theme.shape.borderRadius,
5859
border: `1px solid ${theme.palette.divider}`,
5960
},
61+
tabs: {
62+
minHeight: theme.spacing(3),
63+
},
6064
}),
6165
{ name: 'RaTranslatableInputsTabs' }
6266
);

0 commit comments

Comments
 (0)