Merge pull request #8144 from marmelab/fix-zero-in-autocompleteinput

Fix allow zero as value in AutocompleteInput

Author: slax57

packages/ra-ui-materialui/src/input/AutocompleteInput.spec.tsx

@@ -901,18 +901,32 @@ describe('<AutocompleteInput />', () => {
         );
     });
 
-    it('should accept 0 as an input value', () => {
+    it('should accept 0 as an input value', async () => {
         render(
             <AdminContext dataProvider={testDataProvider()}>
-                <SimpleForm onSubmit={jest.fn()} defaultValues={{ role: 0 }}>
+                <SimpleForm onSubmit={jest.fn()}>
                     <AutocompleteInput
                         {...defaultProps}
                         choices={[{ id: 0, name: 'foo' }]}
                     />
                 </SimpleForm>
             </AdminContext>
         );
-        expect(screen.queryByDisplayValue('foo')).not.toBeNull();
+        const input = screen.getByLabelText(
+            'resources.users.fields.role'
+        ) as HTMLInputElement;
+        input.focus();
+        fireEvent.change(input, { target: { value: 'foo' } });
+        await waitFor(
+            () => {
+                expect(screen.getByRole('listbox').children).toHaveLength(1);
+            },
+            { timeout: 2000 }
+        );
+        fireEvent.click(screen.getByText('foo'));
+        await waitFor(() => {
+            expect(input.value).toEqual('foo');
+        });
     });
 
     it('should support creation of a new choice through the onCreate event', async () => {

packages/ra-ui-materialui/src/input/AutocompleteInput.tsx

@@ -278,7 +278,7 @@ If you provided a React element for the optionText prop, you must also provide t
                 ]);
             }
         } else {
-            field.onChange(getChoiceValue(newValue) || '');
+            field.onChange(getChoiceValue(newValue) ?? '');
         }
     };