Merge pull request #5884 from marmelab/fix-delete-hooks-resource

Fix DeleteWithConfirmButton Does Not Allow to Override resource

Author: fzaninotto

packages/ra-ui-materialui/src/button/DeleteWithConfirmButton.spec.tsx

@@ -74,6 +74,49 @@ describe('<DeleteWithConfirmButton />', () => {
         undoable: false,
     };
 
+    it('should allow to override the resource', async () => {
+        const dataProvider = ({
+            getOne: () =>
+                Promise.resolve({
+                    data: { id: 123, title: 'lorem' },
+                }),
+            delete: jest.fn().mockResolvedValueOnce({ data: { id: 123 } }),
+        } as unknown) as DataProvider;
+        const EditToolbar = props => (
+            <Toolbar {...props}>
+                <DeleteWithConfirmButton resource="comments" />
+            </Toolbar>
+        );
+        const {
+            queryByDisplayValue,
+            getByLabelText,
+            getByText,
+        } = renderWithRedux(
+            <ThemeProvider theme={theme}>
+                <DataProviderContext.Provider value={dataProvider}>
+                    <Edit {...defaultEditProps}>
+                        <SimpleForm toolbar={<EditToolbar />}>
+                            <TextInput source="title" />
+                        </SimpleForm>
+                    </Edit>
+                </DataProviderContext.Provider>
+            </ThemeProvider>,
+            { admin: { resources: { posts: { data: {} } } } }
+        );
+        // waitFor for the dataProvider.getOne() return
+        await waitFor(() => {
+            expect(queryByDisplayValue('lorem')).not.toBeNull();
+        });
+        fireEvent.click(getByLabelText('ra.action.delete'));
+        fireEvent.click(getByText('ra.action.confirm'));
+        await waitFor(() => {
+            expect(dataProvider.delete).toHaveBeenCalledWith('comments', {
+                id: 123,
+                previousData: { id: 123, title: 'lorem' },
+            });
+        });
+    });
+
     it('should allow to override the onSuccess side effects', async () => {
         const dataProvider = ({
             getOne: () =>

packages/ra-ui-materialui/src/button/DeleteWithConfirmButton.tsx

@@ -44,6 +44,7 @@ const DeleteWithConfirmButton: FC<DeleteWithConfirmButtonProps> = props => {
     } = props;
     const translate = useTranslate();
     const classes = useStyles(props);
+    const resource = useResourceContext(props);
     const {
         open,
         loading,
@@ -58,8 +59,8 @@ const DeleteWithConfirmButton: FC<DeleteWithConfirmButtonProps> = props => {
         onClick,
         onSuccess,
         onFailure,
+        resource,
     });
-    const resource = useResourceContext(props);
 
     return (
         <Fragment>

packages/ra-ui-materialui/src/form/Toolbar.tsx

@@ -161,7 +161,10 @@ const Toolbar: FC<ToolbarProps> = props => {
                     Children.map(children, (button: ReactElement) =>
                         button && isValidElement<any>(button)
                             ? React.cloneElement(button, {
-                                  basePath,
+                                  basePath: valueOrDefault(
+                                      button.props.basePath,
+                                      basePath
+                                  ),
                                   handleSubmit: valueOrDefault(
                                       button.props.handleSubmit,
                                       handleSubmit
@@ -173,8 +176,14 @@ const Toolbar: FC<ToolbarProps> = props => {
                                   onSave: button.props.onSave,
                                   invalid,
                                   pristine,
-                                  record,
-                                  resource,
+                                  record: valueOrDefault(
+                                      button.props.record,
+                                      record
+                                  ),
+                                  resource: valueOrDefault(
+                                      button.props.resource,
+                                      resource
+                                  ),
                                   saving,
                                   submitOnEnter: valueOrDefault(
                                       button.props.submitOnEnter,