Skip to content

Commit d677060

Browse files
committed
Fix warning in Field components
Following #8132
1 parent 4d5fb36 commit d677060

11 files changed

+14
-12
lines changed

packages/ra-ui-materialui/src/field/BooleanField.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export const BooleanField: FunctionComponent<BooleanFieldProps> = memo(
6262
className={className}
6363
{...sanitizeFieldRestProps(rest)}
6464
>
65-
{translate(emptyText, { _: emptyText })}
65+
{emptyText && translate(emptyText, { _: emptyText })}
6666
</Typography>
6767
);
6868
}

packages/ra-ui-materialui/src/field/ChipField.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export const ChipField: FC<ChipFieldProps> = memo(props => {
2424
className={className}
2525
{...sanitizeFieldRestProps(rest)}
2626
>
27-
{translate(emptyText, { _: emptyText })}
27+
{emptyText && translate(emptyText, { _: emptyText })}
2828
</Typography>
2929
);
3030
}

packages/ra-ui-materialui/src/field/DateField.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export const DateField: FC<DateFieldProps> = memo(props => {
6565
className={className}
6666
{...sanitizeFieldRestProps(rest)}
6767
>
68-
{translate(emptyText, { _: emptyText })}
68+
{emptyText && translate(emptyText, { _: emptyText })}
6969
</Typography>
7070
) : null;
7171
}

packages/ra-ui-materialui/src/field/EmailField.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export const EmailField: FC<EmailFieldProps> = memo(props => {
2222
className={className}
2323
{...sanitizeFieldRestProps(rest)}
2424
>
25-
{translate(emptyText, { _: emptyText })}
25+
{emptyText && translate(emptyText, { _: emptyText })}
2626
</Typography>
2727
) : null;
2828
}

packages/ra-ui-materialui/src/field/FileField.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export const FileField = (props: FileFieldProps) => {
4848
className={className}
4949
{...sanitizeFieldRestProps(rest)}
5050
>
51-
{translate(emptyText, { _: emptyText })}
51+
{emptyText && translate(emptyText, { _: emptyText })}
5252
</Typography>
5353
) : (
5454
<Root className={className} {...sanitizeFieldRestProps(rest)} />

packages/ra-ui-materialui/src/field/ImageField.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export const ImageField = (props: ImageFieldProps) => {
2323
className={className}
2424
{...sanitizeFieldRestProps(rest)}
2525
>
26-
{translate(emptyText, { _: emptyText })}
26+
{emptyText && translate(emptyText, { _: emptyText })}
2727
</Typography>
2828
) : (
2929
<div className={className} {...sanitizeFieldRestProps(rest)} />

packages/ra-ui-materialui/src/field/NumberField.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export const NumberField: FC<NumberFieldProps> = memo(props => {
6262
className={className}
6363
{...sanitizeFieldRestProps(rest)}
6464
>
65-
{translate(emptyText, { _: emptyText })}
65+
{emptyText && translate(emptyText, { _: emptyText })}
6666
</Typography>
6767
) : null;
6868
}

packages/ra-ui-materialui/src/field/ReferenceField.tsx

+4-2
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export const ReferenceField: FC<ReferenceFieldProps> = props => {
6363
return id == null ? (
6464
emptyText ? (
6565
<Typography component="span" variant="body2">
66-
{translate(emptyText, { _: emptyText })}
66+
{emptyText && translate(emptyText, { _: emptyText })}
6767
</Typography>
6868
) : null
6969
) : (
@@ -184,7 +184,9 @@ export const ReferenceFieldView: FC<ReferenceFieldViewProps> = props => {
184184
return <LinearProgress />;
185185
}
186186
if (!referenceRecord) {
187-
return emptyText ? <>{translate(emptyText, { _: emptyText })}</> : null;
187+
return emptyText ? (
188+
<>{emptyText && translate(emptyText, { _: emptyText })}</>
189+
) : null;
188190
}
189191

190192
let child = children || (

packages/ra-ui-materialui/src/field/ReferenceOneField.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export const ReferenceOneField = (props: ReferenceOneFieldProps) => {
6464
return !record || (!isLoading && referenceRecord == null) ? (
6565
emptyText ? (
6666
<Typography component="span" variant="body2">
67-
{translate(emptyText, { _: emptyText })}
67+
{emptyText && translate(emptyText, { _: emptyText })}
6868
</Typography>
6969
) : null
7070
) : (

packages/ra-ui-materialui/src/field/SelectField.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ export const SelectField: FC<SelectFieldProps> = memo(props => {
102102
className={className}
103103
{...sanitizeFieldRestProps(rest)}
104104
>
105-
{translate(emptyText, { _: emptyText })}
105+
{emptyText && translate(emptyText, { _: emptyText })}
106106
</Typography>
107107
) : null;
108108
}

packages/ra-ui-materialui/src/field/UrlField.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export const UrlField: FC<UrlFieldProps> = memo(props => {
2020
className={className}
2121
{...sanitizeFieldRestProps(rest)}
2222
>
23-
{translate(emptyText, { _: emptyText })}
23+
{emptyText && translate(emptyText, { _: emptyText })}
2424
</Typography>
2525
);
2626
}

0 commit comments

Comments
 (0)