Skip to content

Commit dc6bce6

Browse files
authored
Merge pull request #7642 from marmelab/fix-use-configure-admin-router-from-children-permissions
Simplify useConfigureAdminRouterFromChildren permissions
2 parents 77b526a + 572014d commit dc6bce6

File tree

1 file changed

+2
-21
lines changed

1 file changed

+2
-21
lines changed

packages/ra-core/src/core/useConfigureAdminRouterFromChildren.tsx

+2-21
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
useEffect,
1111
useState,
1212
} from 'react';
13-
import { useLogout, useGetPermissions, useAuthState } from '../auth';
13+
import { useLogout, usePermissions, useAuthState } from '../auth';
1414
import { useSafeSetState } from '../util';
1515
import {
1616
AdminChildren,
@@ -43,7 +43,7 @@ import { useResourceDefinitionContext } from './useResourceDefinitionContext';
4343
export const useConfigureAdminRouterFromChildren = (
4444
children: AdminChildren
4545
): RoutesAndResources & { status: AdminRouterStatus } => {
46-
const permissions = usePermissionsWithLogout();
46+
const { permissions } = usePermissions();
4747

4848
// Whenever children are updated, update our custom routes and resources
4949
const [routesAndResources, status] = useRoutesAndResourcesFromChildren(
@@ -62,25 +62,6 @@ export const useConfigureAdminRouterFromChildren = (
6262
};
6363
};
6464

65-
const usePermissionsWithLogout = () => {
66-
const getPermissions = useGetPermissions();
67-
const doLogout = useLogout();
68-
const [permissions, setPermissions] = useState<any>();
69-
70-
useEffect(() => {
71-
getPermissions()
72-
.then(newPermissions => {
73-
setPermissions(newPermissions);
74-
})
75-
.catch(error => {
76-
console.error(error);
77-
doLogout();
78-
});
79-
}, [doLogout, getPermissions]);
80-
81-
return permissions;
82-
};
83-
8465
/**
8566
* A hook that determine the routes and resources from React nodes and permissions.
8667
* Returns a tuple with the routes and resources as a single object, and the status.

0 commit comments

Comments
 (0)