Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make eventListeners compatible with React 17 #5134

Closed
fzaninotto opened this issue Aug 11, 2020 · 0 comments · Fixed by #5147
Closed

Make eventListeners compatible with React 17 #5134

fzaninotto opened this issue Aug 11, 2020 · 0 comments · Fixed by #5147
Labels
enhancement

Comments

@fzaninotto
Copy link
Member

React 17 is around the corner, and it introduces a breaking change on event listeners (see https://reactjs.org/blog/2020/08/10/react-v17-rc.html#fixing-potential-issues).

I think we must make a change in the 2 occurrences of addEventListener in the react-admin codebase.
@Luwangel Luwangel changed the title MAke eventListeners compatible with React 17 Make eventListeners compatible with React 17 Aug 11, 2020
@WiXSL WiXSL mentioned this issue Aug 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix addEventListener calls for compatibility with React v17. WiXSL/react-admin
2 participants
@fzaninotto @djhi