Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Props to control HideOnScroll behavior of AppBar #6174

Closed
pkspyder007 opened this issue Apr 16, 2021 · 2 comments
Closed

Props to control HideOnScroll behavior of AppBar #6174

pkspyder007 opened this issue Apr 16, 2021 · 2 comments

Comments

@pkspyder007
Copy link

Is your feature request related to a problem? Please describe.
I have a fixed sidebar that is toggled by the App bar for expanding and collapsing. But after scrolling down there is no button to toggle the side menu until the user scrolls back up.

Screen.Recording.2021-04-15.at.9.55.18.PM.mov

Describe the solution you'd like
Ability to control the hideOnScroll behaviour through a prop on AppBar component would be really helpful for enhancing user experience.

Describe alternatives you've considered
Adding a second toggle button behind the appbar in side menu, but that would be redundant.

@pkspyder007
Copy link
Author

@djhi We are using React-admin a lot at Navidrome. There are few suggestions I would like to give.

  • Having the ability for fixed/sticky side menu
  • Changing Menu icon in AppBar on toggling

React-Admin provides the ability to provide a custom implementation for these use-cases but deviates us from the framework. Having the ability to change such properties based on props or some other method will help a lot.
I appreciate the work that you people have put in creating such an amazing technology 🙌

@fzaninotto
Copy link
Member

Fixed by #6178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants