Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many of inputs don't support label={false} #6352

Closed
mohandes-jiri opened this issue Jun 11, 2021 · 4 comments
Closed

Many of inputs don't support label={false} #6352

mohandes-jiri opened this issue Jun 11, 2021 · 4 comments

Comments

@mohandes-jiri
Copy link
Contributor

What you were expecting:
NumberInput, AutoCompleteInput and all inputs support label={false} same as TextInput to hide label

What happened instead:
NumberInput and many input cause error when label prop is false

Steps to reproduce:
Try

  • React-admin version: 3.14.3
@djhi
Copy link
Collaborator

djhi commented Jun 11, 2021

Thanks for reporting this. Many of them (NumberInput for example) actually support it but are missing the proper types and PropTypes. We'll gladly accept PRs to fix that, one input at a time.

@VikrantShirvankar
Copy link
Contributor

Hi..
I would like to work on this issue. This will be my first open source contribution.

@VikrantShirvankar
Copy link
Contributor

Hello..
Raised PR for Number input label issue.
PR
Please let me know if any changes needed.

@fzaninotto
Copy link
Member

Fixed by #6381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants