Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileInput no longer passes source to name attribute, and instead id attribute #7572

Closed
andrico1234 opened this issue Apr 20, 2022 · 1 comment · Fixed by #7619
Closed

FileInput no longer passes source to name attribute, and instead id attribute #7572

andrico1234 opened this issue Apr 20, 2022 · 1 comment · Fixed by #7619
Labels

Comments

@andrico1234
Copy link
Contributor

andrico1234 commented Apr 20, 2022

FileInput no longer receives a name attribute. Instead it gets passed an id attribute instead.

The main problem for us is that it causes our E2E tests to fail (though this is something we will happily update), it also means that there are elements with duplicate IDs (HTML validation issue). e.g.:

image

This is a problem that exists in the CodeSandbox without any changes needed.

Just jump into the Create Post page. Open the element inspector and move to the input type="file" element, and observe the problem

Environment

  • React-admin version: 4.0.1
  • Last version that did not exhibit the issue (if applicable):
  • React version:
  • Browser:
  • Stack trace (in case of a JS error):
@slax57 slax57 added the bug label Apr 21, 2022
@slax57
Copy link
Contributor

slax57 commented Apr 21, 2022

Reproduced, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants