Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation error notification doesn't show for Edit page #8049

Closed
ghost opened this issue Aug 8, 2022 · 2 comments · Fixed by #8055
Closed

Validation error notification doesn't show for Edit page #8049

ghost opened this issue Aug 8, 2022 · 2 comments · Fixed by #8055
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Aug 8, 2022

What you were expecting:
Error notification to be rendered on Edit page just like it did on Create page.

What happened instead:
When a user tries to submit the form on Edit page without filling all the required fields, validation errors are shown below the fields but no notification is shown.
Loom: https://www.loom.com/share/acb982880674400caaa2f16038bbe184
can be properly seen in the loom.

Steps to reproduce:
You can reproduce the error by following the steps shown in the loom in demo example: https://iuxnw.sse.codesandbox.io/#/posts/13

Related code:

insert short code snippets here

Other information:

Environment

  • React-admin version:
  • Last version that did not exhibit the issue (if applicable):
  • React version:
  • Browser:
  • Stack trace (in case of a JS error):
@fzaninotto
Copy link
Member

Good catch! I'm marking this as a bug, thanks for the report.

@fzaninotto fzaninotto added the bug label Aug 8, 2022
@fzaninotto
Copy link
Member

The problem lies in the useIsFormInvalid hook, called by the useAugmentedForm hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants