Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear filter action doesn't appear when filter has alwaysOn props #8277

Closed
JinParc opened this issue Oct 18, 2022 · 1 comment · Fixed by #8324
Closed

Clear filter action doesn't appear when filter has alwaysOn props #8277

JinParc opened this issue Oct 18, 2022 · 1 comment · Fixed by #8324
Labels

Comments

@JinParc
Copy link
Contributor

JinParc commented Oct 18, 2022

Description:

When any filter elements that has alwaysOn as true in filters prop on <List /> component, Remove Filter action menu doesn't appears on Add Filter Button.

I assume, user should be able to remove filter by clicking reset(x mark on the right side of input) button and by clicking Remove Filter menu on Add Filter Button.

What you were expecting:

Remove Filter menu is appeared, even the filter input has alwaysOn prop.
So that, a user can remove all filter by clicking the menu.

What happened instead:

Remove Filter menu doesn't appear on the menu.

code sandbox link : https://codesandbox.io/s/broken-silence-8k4x5u?file=/src/posts/PostList.tsx

Steps to reproduce:

  1. Choose any id on <AutocompleteInput /> that is produced or add any value on <SearchInput /> that is provided
  2. Click Add Filter Button

Environment

  • React-admin version: "^4.2.0"
  • Last version that did not exhibit the issue (if applicable):
  • React version: "^17.0.2",
  • Browser: Chrome
@WiXSL WiXSL added the bug label Oct 19, 2022
@WiXSL
Copy link
Contributor

WiXSL commented Oct 19, 2022

Reproduced. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants