Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagrid isRowSelectable not hiding checkbox #8900

Closed
EdwinCL opened this issue May 10, 2023 · 1 comment · Fixed by #8901
Closed

Datagrid isRowSelectable not hiding checkbox #8900

EdwinCL opened this issue May 10, 2023 · 1 comment · Fixed by #8901

Comments

@EdwinCL
Copy link

EdwinCL commented May 10, 2023 •
edited
Loading

What you were expecting:

According to the documentation, when Datagrid isRowSelectable prop set to false, it will hide the selection checkbox.

What happened instead:

The selection checkbox is disabled instead

Steps to reproduce:

From the tutorial app, add isRowSelectable={() => false} to the datagrid

Related code:

Other information:

Environment

  • React-admin version: 4.10.2
  • Last version that did not exhibit the issue (if applicable):
  • React version: 18.2.0
  • Browser: Firefox
  • Stack trace (in case of a JS error):
@WiXSL WiXSL mentioned this issue May 10, 2023
Merged
@WiXSL
Copy link
Contributor

WiXSL commented May 10, 2023

This behavior was changed in #8650.
But you are right, the documentation needs to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Datagrid's isRowSelectable description and examples WiXSL/react-admin
2 participants
@EdwinCL @WiXSL