Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The assests do not appear to be included in the pypi package... #6

Open
gutow opened this issue May 25, 2022 · 2 comments
Open

The assests do not appear to be included in the pypi package... #6

gutow opened this issue May 25, 2022 · 2 comments

Comments

@gutow
Copy link

gutow commented May 25, 2022

I believe your setup.py is missing a line something like this:
package_data={name:['assets/*.png','assets/*.ico']}

I think that is why I cannot get it to run on my machine when I do a pip install...

@gutow gutow changed the title The assest do not appear to be included in the pypi package... The assests do not appear to be included in the pypi package... May 25, 2022
@gutow
Copy link
Author

gutow commented May 27, 2022

I am not sure my diagnosis is correct. I have forked the repository and tried to run the application locally. I get the same error about logo.ico being undefined. I now believe this is because of MS Windows specific code in the application. I think the issue is related to this discussion.

As Jupyter is primarily run on servers, which primarily run on *nix OSes, I think they need to be supported.

I would really like to include this as part of the Jupyter Physical Science Lab, but it will have to be more platform agnostic for me to be able to use it.

@gutow
Copy link
Author

gutow commented May 27, 2022

This is addressed partially (icon lost on *nix) by pull request #7 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant