Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider experimental preview option #211

Closed
yhatt opened this issue Mar 2, 2020 · 2 comments · Fixed by #232
Closed

Reconsider experimental preview option #211

yhatt opened this issue Mar 2, 2020 · 2 comments · Fixed by #232

Comments

@yhatt
Copy link
Member

yhatt commented Mar 2, 2020

Unfortunately, Carlo, the base technology of experimental --preview option, is no longer maintained. (GoogleChromeLabs/carlo#163 (comment))

In a point of view from tool's maintainabillity, this fact may become a risk for us. So we have to reconsider whether must keep experimental --preview option.

Available options:

  1. Continue using unmaintained Carlo
  2. Switch to well-maintained Carlo forked by community or us
  3. Stop using Carlo, and re-implement --preview option with puppeteer-core (We have already used puppeteer-core for slide conversion)
  4. Stop using Carlo, and remove experimental --preview option

UPDATE: Took option 3 at #232.

@yhatt
Copy link
Member Author

yhatt commented Mar 15, 2020

In Chrome 81 that is going to release in next tuesday, --preview option won't work because of not updated permissions in unmaintained carlo. We have already received some reports about this in #190 and yhatt/marp-cli-example#15.

At the moment we have not a time for maintaining forked carlo. In the next release, we will hide --preview option from help and output an error with keeping the original logic if using --preview option.

UPDATE: Upcoming releases for Chrome >= 81 was paused due to adjusted schedules probably affected by COVID-19. Luckily we are getting time to deprecate preview option during the stable Chrome is still 80.

@yhatt
Copy link
Member Author

yhatt commented Apr 9, 2020

The delayed Chrome 81 was released at April 7th, and no longer work --preview option with it.

For a while I'll track community whether created well-maintained alternative of carlo, but we may have to decide removing --preview if not created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant