Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to allow HTML #10

Closed
yhatt opened this issue Mar 2, 2019 · 4 comments
Closed

Add setting to allow HTML #10

yhatt opened this issue Mar 2, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@yhatt
Copy link
Member

yhatt commented Mar 2, 2019

It is good to be togglable enable or disable HTML as a configuration of extension. It would work as same as --html option in Marp CLI.

Feedbacked to #4 (comment).

@yhatt yhatt added the enhancement New feature or request label Mar 2, 2019
@yhatt
Copy link
Member Author

yhatt commented Mar 8, 2019

An updated VS Code 1.32 is no longer required reload when installing Marp for VS Code. But internally, it means that adding toggleable settings based on an unique Marp instance become be harder.

I have to re-think a logic to toggle HTML by setting, and Marp Core may require update.

@yhatt
Copy link
Member Author

yhatt commented Mar 19, 2019

Shipped with v0.0.6 🚢

@yhatt yhatt closed this as completed Mar 19, 2019
@eric-burel
Copy link
Contributor

That's a great feature, could you add a line about this option in the Readme?
It's very hard to find doc about HTML support in Markdown, either in Marp or with other tools. It's usually supported but it's not always obvious, I had to dig until I found this issue.

Or maybe the fact that HTML is supported should be specified in Marpit doc directly?

@yhatt
Copy link
Member Author

yhatt commented Nov 12, 2019

You're right. Inspite of my fault, I got tired to response troubles caused by missed writing this documentation.

Continue in #98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants