Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code for Web makes broken slide preview on Safari #192

Closed
yhatt opened this issue Jan 30, 2021 · 1 comment · Fixed by #197
Closed

VS Code for Web makes broken slide preview on Safari #192

yhatt opened this issue Jan 30, 2021 · 1 comment · Fixed by #197
Labels
bug Something isn't working

Comments

@yhatt
Copy link
Member

yhatt commented Jan 30, 2021

Confirmed on GitHub Codespaces + iPad Safari: https://twitter.com/y_hatt/status/1313833806940368897?s=20

Ejus00uVcAAjNyR

We would have to consider to re-apply marpit-svg-polyfill for the first time since dropped in #91.
@yhatt yhatt added the bug Something isn't working label Jan 30, 2021
@yhatt
Copy link
Member Author

yhatt commented Feb 7, 2021

By my finding, marpit-svg-polyfill has already run by Marp Core and the polyfill has failed detection of Marpit slide elements.

https://github.com/marp-team/marpit-svg-polyfill/blob/8dbd74dd328f3d27cd17035c087648d8c8140e0b/src/polyfill.ts#L103

That should be firstElementChild, not firstChild.

This was referenced Feb 7, 2021
Merged
Merged
Merged
@yhatt yhatt closed this as completed in #197 Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply patch update of Marp Core for updation of Safari polyfill marp-team/marp-vscode
1 participant
@yhatt