Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

size global directive failed in vs code extension 0.8.0 #61

Closed
fabulist-ssdd opened this issue Aug 1, 2019 · 3 comments · Fixed by #62
Closed

size global directive failed in vs code extension 0.8.0 #61

fabulist-ssdd opened this issue Aug 1, 2019 · 3 comments · Fixed by #62
Assignees
Labels
bug Something isn't working

Comments

@fabulist-ssdd
Copy link

Hi, I have tried out new feature for customized css in 0.8.0. It works fine. However, it seems that the size global directive 4:3 has been somehow deactivated. The only size that worked is 16:9, if I use the size: 4:3, the preview won't change. The exported pdf is fine for 4:3 though.

20190801-marp-issue

I couldn't confirm whether this is an individual case which is just for my end, or ... any way, I am also using the marp web app installed from chrome, the size directive is ok in there.

Looking forward to your reply, THX.

@yhatt yhatt added the bug Something isn't working label Aug 1, 2019
@yhatt
Copy link
Member

yhatt commented Aug 1, 2019

Hmm, certainly size global directive seems not to work. It reproduces in a very simple Markdown too.

---
marp: true
size: 16:9
---

marp-vscode v0.8.0 has added an internal plugin to extend Marp for using custom CSS, but it raises error when using size.

I'll try working to fix it. Thank you for reporting! 😄

@yhatt
Copy link
Member

yhatt commented Aug 1, 2019

It was fixed in v0.8.1. Please update the extension. Sorry for a while of inconvenience.

@fabulist-ssdd
Copy link
Author

It was fixed in v0.8.1. Please update the extension. Sorry for a while of inconvenience.

thanx. it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants