Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependent packages to the latest version #130

Merged
merged 5 commits into from
Mar 22, 2020
Merged

Upgrade dependent packages to the latest version #130

merged 5 commits into from
Mar 22, 2020

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Mar 22, 2020 •
edited
Loading

This PR will upgrade dependent packages to the latest version via yarn upgrade --latest.

Notable changes

  • Upgrade Marp Core to v1.1.0 and Marp CLI to v0.17.3
    • [Marp Core] default theme CSS has a minor fix because of bumped github-markdown-css v4
    • [Marp CLI] PPTX export does no longer make multiple master slides (from v0.17.2)
    • [Marp CLI] Exported HTML is getting more robust against the exception in an edge case (from v0.17.2)
  • Bumped to Prettier v2! ✨
    • Now trailingComma has a default value es5 so removed a specific option from our project.
    • Run yarn format --write to follow new default formatting (arrowParens: always).
  • Bumped Rollup to v2 and its TS plugin to v4.
    • Fixed tsconfig.json to make compatible with rollup plugin.
  • Fix CVE-2020-7598 in deep dependencies tentatively.
    • The same resolutions as Marp CLI have been applied. I suppose fix on these would take a long time to resolve due to including inactive packages.

@yhatt yhatt merged commit 03c3aab into master Mar 22, 2020
@yhatt yhatt deleted the upgrade-dependencies branch March 22, 2020 06:48
@yhatt
Copy link
Member Author

yhatt commented Mar 22, 2020

Due to resolutions for dependent packages, vsce cannot package into VSIX currently. npm does not recognize resolutions field.

Adding --yarn option will success to create VSIX but installed package won't work.

@yhatt yhatt mentioned this pull request Mar 23, 2020
Open
@yhatt yhatt mentioned this pull request Apr 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yhatt