-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uninstallation seems to be done via Package Name #288
Comments
I agree this should be implemented for installs, uninstalls and updates as well. Also, I believe it's better to use --id and -e, like suggested in Winget docs:
|
A quick look at the code I found this: https://github.com/martinet101/WingetUI/blob/main/wingetui/storeEngine.py#L374 Code uses ID and "-e" only if
I found out this code So, if it founds the "..." in the ID, code uses package name. Question is: why ID would have "..." ? Maybe too long string ? Maybe @martinet101 can enlighten us |
We should ask this to winget. Whenever some package names/ids are too long, winget cuts them, ignoring if there's plenty of horixontal space in the console window. When so happens, it uses name. However, this case shouldn't apply here and winget should be defaulting to ID uninstall |
Do you have an example of package name/ID that this issue happens @martinet101 ? |
Did you try the "Format-Table -AutoSize" parameter for Powershell / subprocess.Popen ? https://learn.microsoft.com/en-GB/powershell/module/microsoft.powershell.utility/format-table |
I used the |
which winget version are you using? |
PS C:\WINDOWS\system32> winget --version |
the command |
and with an empty string as a search query? |
That's the thing i was saying. it sometimes does work, it sometimes does not |
I misread this. I thought the "" was to me to fill with something. with an empty string is always truncated |
I've tested it here on cmd and PShell. If the window is maximized I get the full results, if it's a regular window I get the ... EDIT: |
@ppvnf its not the console window. Its how winget print the results on screen when you run |
You mean winget search " " with a space in the middle, now I get it. Thanks. |
Opened an issue there: microsoft/winget-cli#2603 |
The issue with the uninstall failing has been fixed |
It looks like uninstallations are triggered using the Package Name.
This does not work when two installed packages have the same name.
Installations/uninstallations should be triggered using the Package ID.
The text was updated successfully, but these errors were encountered: