Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Add an option to delete desktop shortcut after update/install #2942

Closed
3 tasks done
MrMAXVW opened this issue Nov 6, 2024 · 7 comments · Fixed by #2985
Closed
3 tasks done

[IMPROVEMENT] Add an option to delete desktop shortcut after update/install #2942

MrMAXVW opened this issue Nov 6, 2024 · 7 comments · Fixed by #2985
Assignees
Labels
enhancement An improvement to WingetUI ready-to-go

Comments

@MrMAXVW
Copy link

MrMAXVW commented Nov 6, 2024

Please confirm these before moving forward.

  • I have searched for my feature proposal and have not found a work-in-progress/duplicate/resolved/discarded issue.
  • This improvement refers to an existing feature. If you want to suggest a new feature, please use this template.
  • This improvement is not a bug. If you want to report a bug, please use this template.

Describe the improvement

I was using patchmypc all day long before and discover unigetui recently
this is a pretty good software! but one feature I would like to see is adding an option for user to enable 'auto delete shortcut on desktop after installation'
this is pretty useful for some dudes who have OCD lol

Describe how this improvement could help users

for clean desktop users, they dont need to manually delete the shortcut on desktop
and it should be a pretty easy function to add I guess? thanks a lot

@MrMAXVW MrMAXVW added the enhancement An improvement to WingetUI label Nov 6, 2024
@marticliment marticliment modified the milestones: Bugs, Features Nov 6, 2024
@mrixner
Copy link
Contributor

mrixner commented Nov 6, 2024

I don't think there's a way to find desktop shortcuts automatically, but my suggestion for this would be to have a file selector in the package details page that allows you to select ANY file - presumably re-added by the package on installation / update - like the desktop .lnk file, that UniGetUI would then delete after an update process. Then, it doesn't require any changes to the package managers and still achieves the intended purpose.

@marticliment
Copy link
Owner

There could be some pre and post update scan to detect changed .lnk files

@MrMAXVW
Copy link
Author

MrMAXVW commented Nov 8, 2024

image
Thanks all, here's a printscreen of Patchmypc. I am not sure how they delete the shortcut but it works pretty well.
I think they did scan the desktop for lnk

@mrixner
Copy link
Contributor

mrixner commented Nov 8, 2024

That's a good idea, however in the case of an unrelated .lnk file being added coincidentally to the desktop during installation, for perhaps concurrent installations, I feel there should be a confirmation request the first time it tries to delete a shortcut. Otherwise (because I can't do UI) I would do this right now; this has bothered me for a little while.

Here's what I would recommend - a pre update / post update scan, and if new link files are on and Delete Desktops setting is on, show the user a dialog showing the new link files and ask them to choose which ones to automatically delete in the future.

@Merlin8000
Copy link

I loaded up the issues page to ask for exactly this.

@marticliment
Copy link
Owner

That's a good idea, however in the case of an unrelated .lnk file being added coincidentally to the desktop during installation, for perhaps concurrent installations, I feel there should be a confirmation request the first time it tries to delete a shortcut. Otherwise (because I can't do UI) I would do this right now; this has bothered me for a little while.

That would be an opt-in feature

@mrixner
Copy link
Contributor

mrixner commented Nov 9, 2024

That would be an opt-in feature

Delete Desktops setting is on

Of course it would. Mucking with someone's desktop if they didn't ask you to is a terrible idea.

@marticliment marticliment removed this from the Features milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to WingetUI ready-to-go
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants