Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: out of bounds window positions #1281

Closed
Owyn opened this issue Jan 22, 2024 · 5 comments
Closed

[BUG]: out of bounds window positions #1281

Owyn opened this issue Jan 22, 2024 · 5 comments
Assignees
Labels
Component-GUI Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Milestone

Comments

@Owyn
Copy link
Contributor

Owyn commented Jan 22, 2024

Brief description of the issue

My newly launched clean Lite Portable version out of borders like this
image

same for when I click "advanced mode" after "add a feed"
image

even thought there's enough space on the screen to fully fit the window

How to reproduce the bug?

1 have windows default zoom set to 125%
2 have QT_SCALE_FACTOR env var set to 1.5
3 have 1920x1200 screen resolution

What was the expected result?

fully visible windows

What actually happened?

out of bounds windows

Debug log

rssguard.log

Operating system and version

  • OS: Win 10
  • RSS Guard version: devbuild-cda0f79e1-lite-win10.7z
@Owyn Owyn added the Type-Defect This is BUG!!! label Jan 22, 2024
@martinrotter martinrotter added this to the 4.6.4 milestone Jan 24, 2024
@martinrotter
Copy link
Owner

e48677b

OK, I added automatic logic for all modal dialogs and added the same logic when loading main window.

So now, SIZE of windows should not exceed screen size. POSITION of dialogs is not solved yet.

First, please wait until the fix compiles and test the sizes. If they will be okay, I will fix the positions.

@Owyn
Copy link
Contributor Author

Owyn commented Jan 24, 2024

e48677b

Seems to be working
image
(not sure if the left size is few px out of bounds or not tho 😁 )

advanced mode shows up fine as well:
image

@martinrotter
Copy link
Owner

OK. Added position guarding too.

8e2de8c

Check when compiled and let know.

@Owyn
Copy link
Contributor Author

Owyn commented Jan 24, 2024

image
image
👍

@martinrotter
Copy link
Owner

ok, closing, there are some cases where tweaks would have to be made in the future (like keeping aspect ration of down-sized dialogs etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-GUI Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Projects
None yet
Development

No branches or pull requests

2 participants