Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Chinese characters ignored in RSS URL #1310

Closed
project1188 opened this issue Mar 2, 2024 · 3 comments
Closed

[BUG]: Chinese characters ignored in RSS URL #1310

project1188 opened this issue Mar 2, 2024 · 3 comments
Assignees
Labels
Component-Network Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Milestone

Comments

@project1188
Copy link

project1188 commented Mar 2, 2024

Brief description of the issue

Chinese characters in the RSS URL will be ignored, resulting in incorrect results.

How to reproduce the bug?

step 1:
Add an encoded RSS URL:
https://share.dmhy.org/topics/rss/rss.xml?keyword=%E8%8D%AF%E5%B1%8B%E5%B0%91%E5%A5%B3%E7%9A%84%E5%91%A2%E5%96%83&sort_id=0&team_id=657&order=date-desc,
or a raw RSS URL:
https://share.dmhy.org/topics/rss/rss.xml?keyword=药屋少女的呢喃&sort_id=0&team_id=657&order=date-desc,
step 2:
Fetch selected.

What was the expected result?

Only obtain the results related to "药屋少女的呢喃", the count of message will less then 100

What actually happened?

The request link does not appear to contain Chinese characters: https://share.dmhy.org/topics/rss/rss.xml?keyword=&sort_id=0&team_id=657&order=date-desc, the count of message is 500, it is the max count of limit.

Debug log

time=" 38.621" type="debug" -> feed-downloader: Starting feed updates from worker in thread '0x12cc'.
time=" 38.621" type="debug" -> feed-downloader: All caches synchronized.
time=" 38.621" type="debug" -> database: SQLite database connection 'db_connection_4812' to file 'C:/Users/rsstest/AppData/Local/RSS Guard 4/database/database.db' seems to be established.
time=" 38.623" type="debug" -> feed-downloader: Downloading new messages for feed ID '34' URL: 'https://share.dmhy.org/topics/rss/rss.xml?keyword=药屋少女的呢喃&sort_id=0&team_id=657&order=date-desc' title: 'LoliHouse-動漫花園資源網' in thread '23568'.
time=" 38.623" type="debug" -> database: SQLite database connection 'db_connection_23568' to file 'C:/Users/rsstest/AppData/Local/RSS Guard 4/database/database.db' seems to be established.
time=" 38.624" type="debug" -> core: Downloading URL 'https://share.dmhy.org/topics/rss/rss.xml?keyword=药屋少女的呢喃&sort_id=0&team_id=657&order=date-desc' to obtain feed data.
time=" 38.624" type="debug" -> network: Settings of BaseNetworkAccessManager loaded.
time=" 40.460" type="debug" -> core: Delaying scheduled feed auto-downloads and message state synchronization for some time due to another running update.
time=" 45.100" type="debug" -> network: Destroying Downloader instance.
time=" 45.100" type="debug" -> network: Destroying SilentNetworkAccessManager instance.
time=" 45.523" type="debug" -> feed-downloader: Downloaded 500 messages for feed ID '34',operation took 6899771 microseconds.
time=" 45.526" type="debug" -> database: SQLite connection 'db_connection_23568' is already active.
time=" 45.526" type="debug" -> database: SQLite database connection 'db_connection_23568' to file 'C:/Users/rsstest/AppData/Local/RSS Guard 4/database/database.db' seems to be established.
time=" 45.526" type="debug" -> core: Updating messages in DB.
time=" 45.526" type="debug" -> database: Checking if message with feed-specific custom ID 'http://share.dmhy.org/topics/view/663937_LoliHouse_Chiyu_Mahou_no_Machigatta_Tsukaikata_-_09_WebRip_1080p_HEVC-10bit_AAC.html' is present in DB.
time=" 45.527" type="debug" -> database: Message with custom ID 'http://share.dmhy.org/topics/view/663937_LoliHouse_Chiyu_Mahou_no_Machigatta_Tsukaikata_-_09_WebRip_1080p_HEVC-10bit_AAC.html' is already present in DB and has DB ID '4876'.
[……]
time=" 45.695" type="debug" -> database: Checking if message with feed-specific custom ID 'http://share.dmhy.org/topics/view/657402_LoliHouse_Saihate_no_Paladin_S2_-_09_WebRip_1080p_HEVC-10bit_AAC.html' is present in DB.
time=" 45.695" type="debug" -> database: Message with custom ID 'http://share.dmhy.org/topics/view/657402_LoliHouse_Saihate_no_Paladin_S2_-_09_WebRip_1080p_HEVC-10bit_AAC.html' is already present in DB and has DB ID '4869'.
time=" 45.702" type="debug" -> feed-downloader: Updating messages in DB took 175894 microseconds.
time=" 45.702" type="debug" -> feed-downloader: 0 unread messages and 0 total messages for feed '34' stored in DB.
time=" 45.703" type="debug" -> feed-downloader: Made progress in feed updates, total feeds count 1/1 (id of feed is 34).
time=" 45.771" type="debug" -> feed-downloader: Finished feed updates in thread '0x12cc'.
time=" 45.774" type="debug" -> core: Saved data with auto-saver for 'CookieJar' and method 'saveCookies'.
time=" 45.789" type="debug" -> CTRL is NOT pressed while sorting articles - sorting with standard mode.
time=" 45.795" type="debug" -> message-model: Repopulated model, SQL statement is now:
'SELECT Messages.id, Messages.is_read, Messages.is_important, Messages.is_deleted, Messages.is_pdeleted, Messages.feed, Messages.title, Messages.url, Messages.author, Messages.date_created, Messages.contents, Messages.enclosures, Messages.score, Messages.account_id, Messages.custom_id, Messages.custom_hash, Feeds.title, Feeds.is_rtl, CASE WHEN LENGTH(Messages.enclosures) > 10 THEN 'true' ELSE 'false' END AS has_enclosures, (SELECT GROUP_CONCAT(Labels.name) FROM Labels WHERE Messages.labels LIKE "%." || Labels.custom_id || ".%") as msg_labels, Messages.labels FROM Messages LEFT JOIN Feeds ON Messages.feed = Feeds.custom_id AND Messages.account_id = Feeds.account_id WHERE Feeds.custom_id IN ('34') AND Messages.is_deleted = 0 AND Messages.is_pdeleted = 0 AND Messages.account_id = 1 ORDER BY Messages.date_created DESC;'.
time=" 45.795" type="debug" -> gui: Reloading of msg selections took 7 miliseconds.

Operating system and version

  • OS: windows 11
  • RSS Guard version: 4.6.3
@project1188 project1188 added the Type-Defect This is BUG!!! label Mar 2, 2024
@project1188 project1188 changed the title [BUG]: [BUG]: Chinese characters ignored in RSS URL Mar 2, 2024
@martinrotter
Copy link
Owner

Tested URL: https://share.dmhy.org/topics/rss/rss.xml?keyword=%E8%8D%AF%E5%B1%8B%E5%B0%91%E5%A5%B3%E7%9A%84%E5%91%A2%E5%96%83&sort_id=0&team_id=657&order=date-desc

It returns 21 articles in RSS Guard and I checked with Firefox which also returns 21 articles.

image
image

@martinrotter
Copy link
Owner

However you are right, when I check with RAW, unencoded URL:

https://share.dmhy.org/topics/rss/rss.xml?keyword=药屋少女的呢喃&sort_id=0&team_id=657&order=date-desc

then really it returns 500 characters. Let me fix.

@martinrotter
Copy link
Owner

Fixed with 009aa73

Wait for new version or test with newest devbuild once it compiles.

@martinrotter martinrotter added this to the 4.6.4 milestone Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Network Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Projects
None yet
Development

No branches or pull requests

2 participants