[BUG]: Columns in article list are reset to default when quitting RSSGuard #778
Comments
|
Video: rssguard_column_reset.mp4 |
|
Still occurs after deleting |
Are you sure RSS Guard was not running when you removed the config? Like, minimized to tray? Otherwise, did you ever install development builds/have built on some random git commit ever since you started using your current database file? I remember few months back there were experiments on SQL database with breaking changes that were fixed afterwards, (Maybe there was another such change since then, not sure.) Anyway, if so, git commits are not really supported. On the other note, I can't reproduce it on latest commit.
Even with this column order. Oh, and how are you quitting RSS Guard? Ctrl+Q/Alt+F+Q? Some DE/WM-specific shortcut? |
I don't use tray icon. I'm positive RSSGuard was not running when removing config.ini, I've just tried again and the issue persists. Also tried to remove
Interesting. Yes I did a few days ago. I reported #774 and ran the latest Considering I can reproduce the issue with a fresh config.ini but not with a fresh config.ini and database, maybe using the AppImage caused issues to my database.
I'm using my own Plasma shortcut ( Anyway, I'm going to start from scratch with a new config.ini and database. I'll report back. Thank you! |
|
After starting from scratch, I finally found the culprit. The issue occurs as soon as I uncheck "Use skin colors" in Settings > User Interface and apply.
This change requires a RSSGuard restart and as soon as I restart, the column are reset to default. If I check this setting again, restart RSSGuard as prompted, re-do my columns, exit and restart RSSGuard, my columns are saved as expected. |
|
@xfzv will test, thanks for pinpointing possible cause of this problem. It does seem unlikely for me as the real cause, but will test. |
|
Do you use x11 or wayland? I will have to test on Linux (I use Arch), because on Windows I am not able to reproduce and I tried hard. |
X11 |
@xfzv, Thanks for this! I can reproduce it even with clean profile. It's really weird.
The same happens to many other columns too, not just Feed. Checking "Use skin colors" back fixes the issue for me. Edit: (Compiled against Qt 6.3.1.) |
COmpiled against which qt version? |
5.15.5 |
|
@martinrotter, I can trace it back down to RSS Guard 4.2.0 release (Qt 6.3.1), where that checkbox was introduced (as far as I remember). Can't reproduce it with 0c10e8f compiled against older Qt 5.15.3, but can reproduce it with the same commit compiled against older 6.2.3 (system Qt is 6.3.1, so this test can be incorrect). |
I managed to reproduce it. WTF is happening. World really does not make any sense to me these days. EDIT1: Step 3 is not needed and quitting app via "Quit" button triggers the bug too. |
|
OK, I think I found the problem. It is funny because point 2 caused totally unrelated problem somewhere else in the application, which result in race condition state which essentially caused the settings for columns to be almost completely ignored. There were also some related problems when saving THE setting into settings file. Jesus. Pushed 6e8841e. Pls test when it compiles and report back. I tested in both Qt 5 and Qt 6. |
@martinrotter, Yep. Sorry, I should've mentioned that. Fixed for me. Tested only with Qt 6.3.1 Thanks! |
|
It turned out to by one of the most complicated bugs I had to solve for quite some time in rssguard. I am not still entirely happy with the fix as it feels bit as a hack, and what is worse, the bug manifested bit differently between 5.15.2 and 6.3.1 of Qt. Once Qt 5 will be dumped for good, state will be overally better. I will have to somehow upgrade my scripts to produce Qt 6 appimage. |
Brief description of the issue
Disclaimer: I cannot reproduce with a fresh profile, I have no idea what's going on with my config file.
If I set a new column in the articles list panel (I'd like to have "Feed", which isn't enabled by default) and quit RSSGuard, then after re-launching the app, the columns are reset to default, i.e the "Feed" column is no longer displayed and I have to enable it again manually. Happens with any criteria.
I use
-d, --data /path/to/my/RSSGuard/directorywhere my config.ini and my database are located, if that matters.How to reproduce the bug?
Disclaimer: I cannot reproduce with a fresh profile, I have no idea what's going on with my config file.
What was the expected result?
Columns are memorized after quitting RSSGuard.
What actually happened?
Columns are reset to default after quitting RSSGuard.
Debug log
log
Operating system and version
The text was updated successfully, but these errors were encountered: