Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Feed problem when opening links (because URL of article was prepended with artificial spaces) #914

Closed
ghost opened this issue Apr 11, 2023 · 3 comments
Assignees
Labels
Component-Core Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Milestone

Comments

@ghost
Copy link

ghost commented Apr 11, 2023

Brief description of the issue

When trying to open the links of news from the feed "https://photojournal.jpl.nasa.gov/rss/new" the URL is broken and in turn becomes "https://photojournal.jpl.nasa.gov/%20https://photojournal.jpl.nasa.gov/catalog/PIA25875" instead of being "https://photojournal.jpl.nasa.gov/catalog/PIA25875".

How to reproduce the bug?

  1. Add the feed https://photojournal.jpl.nasa.gov/rss/new to RSS Guard.
  2. Open "news" from the feed.
  3. See the 404 error page from the broken link provided by RSS Guard.

What was the expected result?

The webpage should be in this format: "https://photojournal.jpl.nasa.gov/catalog/PIA25875"

What actually happened?

The webpage was in this format: "https://photojournal.jpl.nasa.gov/%20https://photojournal.jpl.nasa.gov/catalog/PIA25875"

Debug log

io.github.martinrotter.rssguard.desktop[7546]: time=" 10595.231" type="debug" -> gui: Message list got focus with reason 'Qt::ActiveWindowFocusReason'.
io.github.martinrotter.rssguard.desktop[7546]: time=" 10633.714" type="debug" -> gui: Message list got focus with reason 'Qt::ActiveWindowFocusReason'.
io.github.martinrotter.rssguard.desktop[7546]: time=" 10703.893" type="debug" -> gui: Message list got focus with reason 'Qt::ActiveWindowFocusReason'.
io.github.martinrotter.rssguard.desktop[7546]: time=" 10705.133" type="debug" -> gui: Hovered link: 'QUrl(https://photojournal.jpl.nasa.gov/ https://photojournal.jpl.nasa.gov/catalog/PIA25875)'.
io.github.martinrotter.rssguard.desktop[7546]: time=" 10705.167" type="debug" -> gui: Hovered link: 'QUrl()'.
io.github.martinrotter.rssguard.desktop[7546]: time=" 10705.483" type="debug" -> gui: Hovered link: 'QUrl(https://photojournal.jpl.nasa.gov/ https://photojournal.jpl.nasa.gov/catalog/PIA25875)'.
io.github.martinrotter.rssguard.desktop[7546]: time=" 10706.377" type="debug" -> gui: Hovered link: 'QUrl()'.
io.github.martinrotter.rssguard.desktop[7546]: time=" 10708.525" type="debug" -> gui: Hovered link: 'QUrl()'.
io.github.martinrotter.rssguard.desktop[7546]: time=" 10708.988" type="warning" -> javascript: Uncaught TypeError: document.head.appendChild(...) is not a function (source: https://photojournal.jpl.nasa.gov/js/header.js:240)
io.github.martinrotter.rssguard.desktop[7546]: time=" 10754.509" type="debug" -> core: Saved data with auto-saver for 'CookieJar' and method 'saveCookies'.
io.github.martinrotter.rssguard.desktop[7546]: time=" 10780.506" type="debug" -> core: Delaying scheduled feed auto-download for some time since window is focused and updates while focused are disabled by the user and all account caches are empty.

Operating system and version

  • OS: Ubuntu 22
  • RSS Guard version: 4.3.3 Flatpak
@ghost ghost added the Type-Defect This is BUG!!! label Apr 11, 2023
@ghost ghost assigned martinrotter Apr 11, 2023
@martinrotter
Copy link
Owner

Hi, your feed contains semantic errors, specifically:

<link><![CDATA[ https://photojournal.jpl.nasa.gov/catalog/PIA25877]]></link>

It adds space in front of the article URL. But ok, I will fix these in rssguard additionally.

@martinrotter
Copy link
Owner

Fixed, clear your feed data and re-fetch your articles with fixed version.

@martinrotter martinrotter added this to the 4.3.4 milestone Apr 12, 2023
@martinrotter martinrotter changed the title [BUG]: Feed problem when opening links [BUG]: Feed problem when opening links (because URL of article was prepended with artificial spaces) Apr 12, 2023
@martinrotter martinrotter added the Status-Fixed Ticket is resolved. label Apr 12, 2023
@ghost
Copy link
Author

ghost commented Apr 22, 2023

@martinrotter I just updated to the latest version and it worked beautifully :) Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Core Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Projects
None yet
Development

No branches or pull requests

1 participant