lib/settings: try to load from platform config_dir #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemickens
force-pushed
the
config_dir
branch
from
e505ff6 to
19883ba
Compare
arxanas
reviewed
Feb 26, 2022
colemickens
force-pushed
the
config_dir
branch
from
19883ba to
41ada5d
Compare
|
Thanks for both the PR and the review. Do you think we should even drop support for |
|
I didn't want to be too presumptive, if it were me I'd have just removed it entirely, and/or made it an early error if the old location exists. |
|
We're pre-1.0 so I think it's fine to make breaking changes. Making it an early error sounds good to me. With recent format changes in the .jj/ directory, I've written code to automatically upgrade the repo, but in this case I think it's better to error out so the user doesn't miss the fact that the config location moved. |
martinvonz
added a commit
that referenced
this pull request
Feb 27, 2022
Since #85, we load the user's config from a path under `dirs::config_dir()`. It's probably not obvious to all users where to put the file, so let's describe that. (I didn't know where to put the file on my Mac until I looked at the function's documentation.)
martinvonz
added a commit
that referenced
this pull request
Feb 27, 2022
Since #85, we load the user's config from a path under `dirs::config_dir()`. It's probably not obvious to all users where to put the file, so let's describe that. (I didn't know where to put the file on my Mac until I looked at the function's documentation.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84.
{config_dir}/jj/config.toml)~/.jjconfigHere's manual testing showing it working from both locations and erroring when both are present: