Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Signage Point regex to comply with Windows log format #254

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Update Signage Point regex to comply with Windows log format #254

merged 1 commit into from
Jul 9, 2021

Conversation

pieterhelsen
Copy link
Collaborator

Fixes #253

See #253 for details.

@pieterhelsen pieterhelsen added bug Something isn't working windows labels Jul 8, 2021
@pieterhelsen pieterhelsen linked an issue Jul 8, 2021 that may be closed by this pull request
[BUG] Signage Points are not parsed on Windows #253
Closed
martomi
martomi approved these changes Jul 9, 2021
View reviewed changes
Copy link
Owner

@martomi martomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch, thanks Pieter! 🎉

@martomi martomi merged commit c7135fb into dev Jul 9, 2021
@martomi martomi deleted the bugfix/windows-signage-points branch July 9, 2021 20:05
@martomi martomi mentioned this pull request Jul 19, 2021
Merged
jinnatar pushed a commit to jinnatar/chiadog that referenced this pull request Feb 5, 2023
@pieterhelsen
Update regex to comply with Windows log format (martomi#254)
92fea7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martomi martomi martomi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Signage Points are not parsed on Windows
2 participants
@pieterhelsen @martomi