Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations #137

Open
bvanrijn opened this issue Aug 9, 2016 · 11 comments · May be fixed by #601
Open

Translations #137

bvanrijn opened this issue Aug 9, 2016 · 11 comments · May be fixed by #601

Comments

@bvanrijn
Copy link

bvanrijn commented Aug 9, 2016

I think it would be cool if Museeks was translatable. I can contribute a Dutch translation.

@martpie
Copy link
Owner

martpie commented Aug 9, 2016

Hey @bvanrijn !

Translations are something we're thinking about. The main question is "where to manage these translations", it will probably be with a product like Transifex or any alternative. I would prefer not to manage them directly on the repository.

Considering the technical aspect of it, react-intl seems like the way to go.

Specs

  • The translations are not managed in this Github project

Todo

  • Choose a library to translate components (react-intl ?)
  • Choose a service to host those translations (Transifex, Github, whatever), where translations will be maintained
  • English translation first
  • If it goes well, open to other languages
  • Language selector component in the settings ? (+ auto-determinate OS language ?)
  • Adapt the dev builds to fetch those translations or fetch them manually ?

@martpie martpie added this to the 1.0 milestone Aug 9, 2016
@ghost
Copy link

ghost commented Aug 9, 2016

@KeitIG Transifex is good, and powerful. I think it'll be enough for Museeks (elementary is using it by the way).

@kellertobias
Copy link

I would do the german translation, if my Ideas #146 or #143 are getting addressed (I am available after 24. Sept 2016)

@martpie
Copy link
Owner

martpie commented Aug 24, 2016

I've update my first comment to add specs/tasks. I don't think it will be done soon anyway, because a lot of things has still to be done, and I don't really want to wait for translations to be ready at every release.

@martpie martpie mentioned this issue Sep 21, 2016
18 tasks
@BlueManCZ
Copy link

I don't know, if this has any update, but guy who develop Min browser, has translations done trough .json files and everybody, who can contribute, just create a copy of en-US and translate it to new language.

@martpie
Copy link
Owner

martpie commented Apr 4, 2018

I had to use i18next recently, in combination of react-i18next, it worked perfectly, and this is probably what we will use. I do not want to implement it now though, because the UI is still changing and I do not want to wait of external contributors to do a release if a string is not translated ;)

@YurySolovyov
Copy link
Collaborator

I'm not sure if this approach is widely used, but I think English translation should act as baseline and other translations are "merged" (deep merge that is) into it. This way you never have a missing translations because English one is always up to date.

@igorer88
Copy link
Contributor

igorer88 commented Mar 3, 2019

I can help with the Spanish translation :)

@binyamin
Copy link

I can do hebrew translations

@martpie martpie modified the milestones: 1.0, 0.13 Jul 29, 2021
@martpie
Copy link
Owner

martpie commented Jul 29, 2021

Probably what will come next :D

@martpie martpie linked a pull request Aug 1, 2021 that will close this issue
8 tasks
@bogosorter
Copy link

I can do the Portuguese translation!

@martpie martpie modified the milestones: 0.13, 1.0 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants