-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow integers as tag values #9
Comments
Both fjall and talna are both awesome. Also add support more dataypes for Value, such as integer,boolean or even string ? :) |
Tag values are strictly strings right now: Line 101 in cb7581e
Adding boolean shouldn't be too hard when integers are added, because it's just one more enum variant |
Oh, sorry for my mislead. I am talking about field Value which is only f64 or f32 for now. It can also be in newtype for number or enum style :) No native support for other number types or boolean is fine, maybe just need some handy Into/From helpers. |
Considering it's a timeseries database, anything but numbers doesn't really make sense - integers could work, but I think floats are enough for typical metrics workloads. |
No problem, integer support may make aggregation or other things more complicated. The data conversion can be done in client side. Anyway, thanks for your quick response 💯 |
e.g. Give me the COUNT of requests for
service:rest-api AND http.res.code:[400 TO 499]
The text was updated successfully, but these errors were encountered: