Skip to content

Commit

Permalink
feat(generators): remove madlib-console
Browse files Browse the repository at this point in the history
It doesn't cover the full console API and messages don't show the original source code line number. It is confusing things more than that is helping.
Also, since console statements are nuked from non-debug builds anyway, the last remaining pro of this module is effectively rendered defunct.
  • Loading branch information
cueedee committed Jul 22, 2015
1 parent f0c1099 commit cfe343f
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 14 deletions.
1 change: 0 additions & 1 deletion generators/app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,6 @@ var AppGenerator = generators.Base.extend(
[
'backbone'
, ( 'jquery' + ( data.ie8 ? '@<2' : '' ))
, 'madlib-console'
, 'madlib-hostmapping'
, 'madlib-settings'
, 'q'
Expand Down
4 changes: 0 additions & 4 deletions generators/app/templates/src/app.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,6 @@ do () ->
## [madlib]
##

## https://github.com/Qwerios/madlib-console#readme
##
console = require( 'madlib-console' )

## https://github.com/Qwerios/madlib-settings#readme
##
settings = require( 'madlib-settings' )
Expand Down
9 changes: 3 additions & 6 deletions generators/app/templates/src/router.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
module.exports = factory(
require( 'backbone' )
require( 'underscore' )
require( 'jquery' )
require( 'madlib-console' )<% if ( i18n ) { %>
require( 'jquery' )<% if ( i18n ) { %>
require( 'madlib-locale' )<% } %>

require( './views/index.coffee' )
Expand All @@ -13,17 +12,15 @@
define( [
'backbone'
'underscore'
'jquery'
'madlib-console'<% if ( i18n ) { %>
'jquery'<% if ( i18n ) { %>
'madlib-locale'<% } %>

'./views/index.coffee'
], factory )
)((
Backbone
_
$
console<% if ( i18n ) { %>
$<% if ( i18n ) { %>
localeManager<% } %>

Views...
Expand Down
3 changes: 0 additions & 3 deletions generators/demo/templates/src/router.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
require( 'backbone' )
require( 'underscore' )
require( 'jquery' )
require( 'madlib-console' )
require( './views/navigation.coffee' )
require( './views/index.coffee' )
require( './views/i18n.coffee' )
Expand All @@ -16,7 +15,6 @@
'backbone'
'underscore'
'jquery'
'madlib-console'
'./views/navigation.coffee'
'./views/index.coffee'
'./views/i18n.coffee'
Expand All @@ -27,7 +25,6 @@
Backbone
_
$
console

NavigationView

Expand Down

0 comments on commit cfe343f

Please sign in to comment.