You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
toml++ version and/or commit hash:
v3 - commit hash 5c5abfd
Compiler:
MSVC 2022
C++ standard mode:
latest
Target arch:
x64
Library configuration overrides:
None.
Relevant compilation flags:
None.
Describe the bug
The definition of array::insert_at in array.inl is preceded by TOML_API rather than TOML_EXTERNAL_LINKAGE (inline) as the other functions in the file are. This is causing ODR violations in my project.
The text was updated successfully, but these errors were encountered:
@Azarael It occurred to me that the reason you experienced this and I hadn't was the combination of TOML_HEADER_ONLY and including the library in multiple translation units. FYI you can improve your compile times by disabling TOML_HEADER_ONLY and defining TOML_IMPLEMENTATION in a single TU (ref: Speeding up compilation)
Having said that, I'm thankful you did experience it, so I could fix it! 😄
Environment
toml++ version and/or commit hash:
v3 - commit hash 5c5abfd
Compiler:
MSVC 2022
C++ standard mode:
latest
Target arch:
x64
Library configuration overrides:
None.
Relevant compilation flags:
None.
Describe the bug
The definition of
array::insert_at
in array.inl is preceded byTOML_API
rather thanTOML_EXTERNAL_LINKAGE
(inline) as the other functions in the file are. This is causing ODR violations in my project.The text was updated successfully, but these errors were encountered: