🐛 [BUG] mas outdated does not show updates for "Grammarly for Safari"

[chris-araman]

Environment

• mas version: 1.8.2 from Homebrew core, and main built from source
• macOS: 11.3.1

mas Install Method

• brew install mas (homebrew-core, 1.8.2)
• Built from source (main, Xcode 12.5)

Describe the Bug

mas outdated and mas upgrade do not show an upgrade for "Grammarly for Safari" (id 1462114288), though mas list does list it as being installed.

To Reproduce

Steps to reproduce the behavior:

1. mas install 1462114288
2. Wait for a Grammarly update to be released.
3. mas outdated or mas upgrade 1462114288

Expected Behavior

• The Safari extension should be updated.

Actual Behavior

• No upgrade is reported, and nothing is upgraded.

Additional Context

• Commenting out this line fixes the issue:
  

  mas/Sources/MasKit/Controllers/StoreSearch.swift

  Line 82 in 585699d

  URLQueryItem(name: "entity", value: "macSoftware"),

It seems there are other entities we need to handle in our searches. This is likely related to the issues around iOS/iPadOS apps on M1 Macs as well.

[chris-araman]

I think this is just more of the eventual consistency issue (Akamai cache).

mas outdated eventually saw the update with no changes to code. I am skeptical that the entity change had an impact; I think I just got lucky.