Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI test coverage #253

Closed
1 of 3 tasks
Tracked by #83
mudler opened this issue Sep 24, 2024 · 3 comments · Fixed by #288
Closed
1 of 3 tasks
Tracked by #83

Add CI test coverage #253

mudler opened this issue Sep 24, 2024 · 3 comments · Fixed by #288
Assignees
Labels

Comments

@mudler
Copy link
Contributor

mudler commented Sep 24, 2024

Problem

We want to assess the code quality, but we don't know the test coverage of the code

Action item

  • Collect coverage of current unit tests automatically
  • Use a service like codecov to upload the coverage
  • Use a service like codecov and hook it to the CI/CD to allow us to evaluate the code coverage
@giovaroma
Copy link

Bittensor removed functionality from BT SDK and now need to figure out how to fix this. Working with Bittensor to come up with a solution.

@hide-on-bush-x
Copy link
Contributor

Some notes about what happened:

  • Bittensor SDK update removed all the mocks we were using to test, it seems like they are not bringing them back ( conversation in the church of rao )
  • Since that broke our old unittests we needed to figure out how achieve some E2E
    • Decided to test on BT Testnet subnet 165
      - This requires testnet registered wallets to work ( cc @john Durkin, we are going to set up a common set of wallets for this kind of dev purposes on 1p )
  • Got some minimal tests running for the miner and the validator and got coverage report from it
    - There is a script inside the tests folder that takes care of running those tests and get the report, its important to use it because if we run the tests in parallel it fails ( it has to be secuential )

@Luka-Loncar
Copy link
Collaborator

Follow up task #294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants