Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create method changed to NewId #121

Merged
merged 1 commit into from
Jul 5, 2022
Merged

chore: Create method changed to NewId #121

merged 1 commit into from
Jul 5, 2022

Conversation

zhenlei520
Copy link
Contributor

Description

IdGenerator: Create method changed to NewId

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 requested a review from doddgu July 4, 2022 10:54
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doddgu doddgu merged commit 1e8833a into main Jul 5, 2022
@doddgu doddgu deleted the chore/idGenerator branch July 5, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants