Skip to content

Commit d773522

Browse files
authored
⚡ Refactor: Possible null reference assignment (#729)
* 🐛 fix: Fix BlazorCurrentPrincipalAccessor in BlazorWebAssembly * test: Adjust unit testing * ⚡ Refactor: Possible null reference assignment * ⚡ refactor: Eliminate code odor
1 parent b757ee5 commit d773522

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/Contrib/Authentication/Identity/Masa.Contrib.Authentication.Identity.BlazorWebAssembly/MasaComponentsClaimsCache.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace Masa.Contrib.Authentication.Identity.BlazorWebAssembly;
66
public class MasaComponentsClaimsCache : IScopedDependency
77
{
88
public ClaimsPrincipal Principal { get; private set; }
9-
private readonly AuthenticationStateProvider _authenticationStateProvider;
9+
private readonly AuthenticationStateProvider? _authenticationStateProvider;
1010

1111
public MasaComponentsClaimsCache(
1212
IClientScopeServiceProviderAccessor serviceProviderAccessor)

src/Contrib/Authentication/Identity/Tests/Masa.Contrib.Authentication.Identity.BlazorWebAssembly.Tests/IdentityTest.cs

+8-8
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,10 @@ public async Task TestIdentityByYamlAsync()
105105

106106
var userRoles = userContext.GetUserRoles<int>().ToList();
107107
Assert.AreEqual(4, userRoles.Count);
108-
Assert.AreEqual(true, userRoles.Contains(1));
109-
Assert.AreEqual(true, userRoles.Contains(3));
110-
Assert.AreEqual(true, userRoles.Contains(7));
111-
Assert.AreEqual(true, userRoles.Contains(12));
108+
Assert.IsTrue(userRoles.Contains(1));
109+
Assert.IsTrue(userRoles.Contains(3));
110+
Assert.IsTrue(userRoles.Contains(7));
111+
Assert.IsTrue(userRoles.Contains(12));
112112
}
113113

114114
[TestMethod]
@@ -154,9 +154,9 @@ public async Task TestIdentityByYamlAndCustomOptionsAsync()
154154

155155
var userRoles = userContext.GetUserRoles<int>().ToList();
156156
Assert.AreEqual(4, userRoles.Count);
157-
Assert.AreEqual(true, userRoles.Contains(1));
158-
Assert.AreEqual(true, userRoles.Contains(3));
159-
Assert.AreEqual(true, userRoles.Contains(7));
160-
Assert.AreEqual(true, userRoles.Contains(12));
157+
Assert.IsTrue(userRoles.Contains(1));
158+
Assert.IsTrue(userRoles.Contains(3));
159+
Assert.IsTrue(userRoles.Contains(7));
160+
Assert.IsTrue(userRoles.Contains(12));
161161
}
162162
}

0 commit comments

Comments
 (0)