Skip to content

Commit f7e1331

Browse files
fix: Code Smells
1 parent 9bf63a3 commit f7e1331

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

src/BuildingBlocks/Caching/Masa.BuildingBlocks.Caching/CacheClientBase.cs

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ public abstract class CacheClientBase : ICacheClient
77
{
88
public abstract IEnumerable<T?> GetList<T>(params string[] keys);
99

10-
1110
public abstract Task<IEnumerable<T?>> GetListAsync<T>(params string[] keys);
1211

1312
public virtual void Set<T>(string key, T value, DateTimeOffset? absoluteExpiration, Action<CacheOptions>? action = null)

src/Contrib/Caching/Distributed/Masa.Contrib.Caching.Distributed.StackExchangeRedis/RedisCacheClient.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public RedisCacheClient(IOptionsMonitor<RedisConfigurationOptions> redisConfigur
1717
{
1818
if (optionName == name)
1919
{
20-
InitRedisConfigurationOptions(option);
20+
InitializeRedisConfigurationOptions(option);
2121
GlobalCacheOptions = option.GlobalCacheOptions;
2222
}
2323
});

src/Contrib/Caching/Distributed/Masa.Contrib.Caching.Distributed.StackExchangeRedis/RedisCacheClientBase.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ protected RedisCacheClientBase(RedisConfigurationOptions redisConfigurationOptio
1818
{
1919
GlobalCacheOptions = redisConfigurationOptions.GlobalCacheOptions;
2020
var redisConfiguration = GetRedisConfigurationOptions(redisConfigurationOptions);
21-
InitRedisConfigurationOptions(redisConfiguration);
21+
InitializeRedisConfigurationOptions(redisConfiguration);
2222

2323
GlobalJsonSerializerOptions = jsonSerializerOptions ?? new JsonSerializerOptions().EnableDynamicTypes();
2424
}
2525

26-
protected void InitRedisConfigurationOptions(RedisConfigurationOptions redisConfigurationOptions)
26+
protected void InitializeRedisConfigurationOptions(RedisConfigurationOptions redisConfigurationOptions)
2727
{
2828
Dispose();
2929

@@ -245,7 +245,7 @@ private static DataCacheModel MapMetadataByAutomatic(string key, RedisValue[] re
245245
return new DataCacheModel(key, absoluteExpiration, slidingExpiration, data);
246246
}
247247

248-
public override void Dispose()
248+
public sealed override void Dispose()
249249
{
250250
Connection?.Dispose();
251251
}

src/Contrib/Caching/Masa.Contrib.Caching.MultilevelCache/MultilevelCacheClient.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -667,10 +667,9 @@ private void Subscribe<T>(
667667

668668
#endregion
669669

670-
public override void Dispose()
670+
public sealed override void Dispose()
671671
{
672672
_distributedCacheClient?.Dispose();
673673
_memoryCache?.Dispose();
674674
}
675-
676675
}

0 commit comments

Comments
 (0)