Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Masa.BuildingBlocks.Caching , this second class name is inappropriate.DistributedCacheClientFactoryBase,MultilevelCacheClientFactoryBase #490

Closed
MapleWithoutWords opened this issue Mar 11, 2023 · 1 comment · Fixed by #499
Closed

In Masa.BuildingBlocks.Caching , this second class name is inappropriate.DistributedCacheClientFactoryBase,MultilevelCacheClientFactoryBase #490

MapleWithoutWords opened this issue Mar 11, 2023 · 1 comment · Fixed by #499

Comments

@MapleWithoutWords
Copy link
Member

MapleWithoutWords commented Mar 11, 2023 •
edited
Loading

In Masa.BuildingBlocks.Caching

The name of 'DistributedCacheClientFactoryBase' looks like an abstract class, and I think 'DistributedCacheClientFactory' is a good name for it.

image
@MapleWithoutWords MapleWithoutWords changed the title In Masa.BuildingBlocks.Caching , this three class name is inappropriate.CacheClientFactoryBase,DistributedCacheClientFactoryBase,MultilevelCacheClientFactoryBase In Masa.BuildingBlocks.Caching , this second class name is inappropriate.DistributedCacheClientFactoryBase,MultilevelCacheClientFactoryBase Mar 11, 2023
@zhenlei520
Copy link
Contributor

Unify the default implementation with DefaultXXX

@zhenlei520 zhenlei520 linked a pull request Mar 30, 2023 that will close this issue
fix:'DistributedCacheClientFactoryBase,MultilevelCacheClientFactoryBase' class name is inappropriate #499
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zhenlei520 @MapleWithoutWords