Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot terminate sidecar when program exits abnormally #598

Merged
merged 7 commits into from
May 8, 2023

Conversation

zhenlei520
Copy link
Contributor

Description

Cannot terminate sidecar when program exits abnormally

Issue reference

issues-507

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zhenlei520 zhenlei520 requested review from MayueCif and doddgu May 5, 2023 13:36
@zhenlei520 zhenlei520 force-pushed the fix/issues-507 branch 6 times, most recently from ccec5e0 to 567f019 Compare May 6, 2023 05:16
@zhenlei520 zhenlei520 marked this pull request as ready for review May 6, 2023 05:35
@zhenlei520 zhenlei520 linked an issue May 6, 2023 that may be closed by this pull request
@zhenlei520 zhenlei520 added this to the 1.0.0-rc.2 milestone May 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.4% 83.4% Coverage
0.0% 0.0% Duplication

@zhenlei520 zhenlei520 requested a review from doddgu May 6, 2023 10:47
@doddgu doddgu merged commit 8ce3a65 into main May 8, 2023
@doddgu doddgu deleted the fix/issues-507 branch May 8, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

直接关闭 VS 或者程序 dapr 边车没有退出
2 participants