Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SchedulerWorkerManagerData.StopTask does not clean the running task id #455

Open
Mrmantou opened this issue Jun 7, 2023 · 1 comment
Open

SchedulerWorkerManagerData.StopTask does not clean the running task id #455

Mrmantou opened this issue Jun 7, 2023 · 1 comment
Assignees
@wzh425
Labels
status/resolved The issue has been settled

Comments

@Mrmantou
Copy link

Mrmantou commented Jun 7, 2023

When stop a task in worker side,
If the task is waitting in SchedulerWorkerManagerData.TaskQueue, the task id added to SchedulerWorkerManagerData.StopTask and remove after deaqueue from task queue,
if the task is running, the task id add to SchedulerWorkerManagerData.StopTask, but not be removed.
@wzh425 wzh425 self-assigned this Jun 15, 2023
@wzh425 wzh425 mentioned this issue Jun 15, 2023
Merged
@wzh425 wzh425 added the status/resolved The issue has been settled label Jun 30, 2023
@Mrmantou
Copy link
Author

Mrmantou commented Aug 2, 2023

I do not think it is a good way to remove the task added to SchedulerWorkerManagerData.StopTask.
It is used in judging a task cancled manually or timeout. @wzh425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wzh425 wzh425

Labels
status/resolved The issue has been settled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wzh425 @Mrmantou