Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.6.8 always transferring full snapshots #32

Closed
zlarf opened this issue Jun 26, 2016 · 3 comments
Closed

v0.6.8 always transferring full snapshots #32

zlarf opened this issue Jun 26, 2016 · 3 comments
Labels

Comments

@zlarf
Copy link

zlarf commented Jun 26, 2016

Hi.

Since upgrading from v.0.6.4 to v0.6.8, incremental backups do not work. Full snapshots are always sent without any warning message.

With a quick look it seems to me, that the culprit is commit 8e54abc.

It looks like that with this:
if self.destination is not None: [snip] else: source_parent_path = os.path.join(self.source.container_subvolume_path, str(self.source.snapshots[0].name))
...the source_parent_path is only set if there are no destination snapshots.

@masc3d
Copy link
Owner

masc3d commented Jun 26, 2016

indeed, a careless mistake with severe consequences. thanks for pointing it out, fix is on the way.

@masc3d masc3d added the bug label Jun 26, 2016
@masc3d masc3d closed this as completed in 80a74b3 Jun 26, 2016
@masc3d
Copy link
Owner

masc3d commented Jun 26, 2016

pushed 0.6.9 to pypi

@zlarf
Copy link
Author

zlarf commented Jun 26, 2016

Nice, a quick fix. ...and thanks for the great software!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants