-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOLVED] No valid XML returned for AudioPro Speakers #363
Comments
It's very silent here, and the last commit is 1,5y old. Is this project abandoned? |
I just stumbled across the same problem with my Samsung e750 speakers. The problem seems to be the leading whitespace in line 4: |
You are right, how did I miss that. Not sure if that makes the error, but it seems like the closest solution. I just wounder if the problem lay within pulseaudio-dlna itself, or one of the dependence that render the xml itself. |
@risingape I just looked again and compared my AudioPro with my Sony speaker. Sony did not include xmlns:ms=" urn:microsoft-com:wmc-1-0" at all, but AudioPro do. Guess your Samsung have this string to? |
Of course, I am not 100% certain yet. But I parsed the corrected XML response successfully. |
@risingape Sounds that this could be the issue then. I'm trying to review the code and see if there is something I can change. Never coded in Python before, so i'm not sure if I will find a solution though. How did you feed the correct code to pa-dlna? Tried it once, but never got it to work. |
I added some debugging code to render.py, that showed the output of the repaired XML code (in debug mode you get error Got broken xml, trying to fix it before No valid XML returned..). The output there seems to actually fix the whit space problem, the output I got from xml string on line 565 is xmlns:ms="urn:microsoft-com:wmc-1-0", but still throws an error. Original output:
Fixed output (my own added code):
|
Ha! I found the problem. It seems to be a error when applying workarounds. If I commented out line 554-557 in /usr/lib/python2.7/site-packages/pulseaudio_dlna/plugins/upnp/render.py I got everything to work. It was nothing in the XML file itself that trow this error.
It's a error in the if statement if device_manufacturer is not None and \ device_manufacturer.text.lower() == 'yamaha corporation'. In my AudioPro the device_manufacturer string was empty in the XML, hence trowing the error. |
Great! Yes, I can confirm. |
It's not a perfect solution, but it works if you don't have any Yamaha stuff in your network. |
I just installed pulseaudio-dlna on KaOS installation, and it works great for some of my speakers (Sony and Chomecast). But fails on my two AudioPro speakers. They work with other soulutions like AirAudio and BubbleUPnP (Android) and Kodi.
Get the error No valid XML returned.. from the output. I looked at the URL, and I see the xml itself, and it looks legit (comparing to the Sony).
Here's the XML from it;
The text was updated successfully, but these errors were encountered: