Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mason fails to resolve JDTLS version for older milestones #3017

Open
dorin-suletea opened this issue Oct 8, 2023 · 3 comments
Open

Mason fails to resolve JDTLS version for older milestones #3017

dorin-suletea opened this issue Oct 8, 2023 · 3 comments

Comments

@dorin-suletea
Copy link

dorin-suletea commented Oct 8, 2023

:MasonInstall jdtls@1.26.0 fails with Failed to download file : https://download.eclipse.org/jdtls/milestones/1.26.0/jdt-language-server-1.26.0-202309281329.

The actual version published is : https://www.eclipse.org/downloads/download.php?file=/jdtls/milestones/1.26.0/jdt-language-server-1.26.0-202307271613.tar.gz

The suffix -202309281329 matches latest jdtls version (1.28.0) https://www.eclipse.org/downloads/download.php?file=/jdtls/milestones/1.28.0/jdt-language-server-1.28.0-202309281329.tar.gz

I believe this happens as the suffix is hardcoded : 80bd37e

Might be somewhat related to this : williamboman/mason.nvim#286

@zenoli
Copy link

zenoli commented Oct 10, 2023

I made an issue for this on the mason repo as well a couple of days ago

@mikehaertl
Copy link

Following the purl specs I wonder if we could add the required timestamp a qualifier to the package id:

id: pkg:generic/eclipse/eclipse.jdt.ls@v1.34.0?timestamp=202404031240

This should make it easy to reference it in the source.file.download section.

Alternatively we could append it to the version separated with a dash:

id: pkg:generic/eclipse/eclipse.jdt.ls@v1.34.0-202404031240

Then split it with an expression to create the final download URL.

@BKR-dev
Copy link

BKR-dev commented Oct 10, 2024

you can use :MasonInstall jdtls@v1.38.0 to get the next version going since 1.37.0 is also broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants