Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup of: Fix DB serialization order for Ord types #4621

Open
3 tasks
Leo-Besancon opened this issue Jan 9, 2024 · 0 comments
Open
3 tasks

Followup of: Fix DB serialization order for Ord types #4621

Leo-Besancon opened this issue Jan 9, 2024 · 0 comments
Labels
enhancement New feature or request global Issue that concern the whole codebase

Comments

@Leo-Besancon
Copy link
Collaborator

Leo-Besancon commented Jan 9, 2024

Follow-up of: #4619
Please look at the PR comments for additionnal context.

Non critical instances that we may want to better handle

  • In the AsyncPool, the keys in the DB are AsyncMessageId that are Ord and partly encoded as Varint. We do not (currently) use this Ord, but may in the future).
  • Executed Denunciations are indexed by DenunciationIndexed that are Ord and partly encoded as Varint.. We do not (currently) use this Ord, but may in the future)
  • MIP Info related keys, but we don't iter on them in the DB, we query all of them at start.
@AurelienFT AurelienFT added enhancement New feature or request global Issue that concern the whole codebase labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request global Issue that concern the whole codebase
Projects
None yet
Development

No branches or pull requests

2 participants