Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Account Persistence on Zustand #922

Closed
mazmassa opened this issue Jun 29, 2023 · 4 comments · Fixed by #1313
Closed

Remove Account Persistence on Zustand #922

mazmassa opened this issue Jun 29, 2023 · 4 comments · Fixed by #1313
Assignees
Labels
Frontend tech technical task

Comments

@mazmassa
Copy link
Contributor

mazmassa commented Jun 29, 2023

Context
We are storing in local browser storage unnecessary content.

User flow
There's NO UX/UI involved here. Pure tech aspects.

How to

  • Open the browser, switch/select an account.
  • Open the console, pick Application tab.

You should see the accounts content stored.

Technical details
We have some stores already defined in Zustand.

Between them we have one called Account that is persisted in the browser local storage. We should remove that persistence once it does not make sense (now) to have it.

QA testing

  • Open the browser, switch/select an account.
  • Open the console, pick Application tab.

You should not see any account content stored.

@SlnPons
Copy link
Contributor

SlnPons commented Jun 29, 2023

Hey @mazmassa thanks for the issue. Could you add more info about the user benefit in the description please?
Without the info in the template, it's hard to prioritise because it's hard to compare ;)
Cheers

@mazmassa
Copy link
Contributor Author

Hey @mazmassa thanks for the issue. Could you add more info about the user benefit in the description please? Without the info in the template, it's hard to prioritise because it's hard to compare ;) Cheers

Just updated!

@Thykof
Copy link
Contributor

Thykof commented Aug 11, 2023

I think we implemented that way to anticipate a UX requiring selection of the account across pages

@Thykof Thykof added the tech technical task label Aug 11, 2023
@mazmassa
Copy link
Contributor Author

I think we implemented that way to anticipate a UX requiring selection of the account across pages

The way we did was storing the whole object in the storage... what is definitely not good. We should persist only the address. Just did that for bridge we can use the same logic.

@loonggamma loonggamma removed the P3 label Oct 17, 2023
@Thykof Thykof self-assigned this Jan 5, 2024
@Thykof Thykof linked a pull request Jan 5, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend tech technical task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants