Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow Equipped Items to Add Weapon Types #2181

Open
msprijatelj opened this issue Feb 1, 2023 · 1 comment
Open

[FEATURE] Allow Equipped Items to Add Weapon Types #2181

msprijatelj opened this issue Feb 1, 2023 · 1 comment
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@msprijatelj
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There is a design space for equipped items to allow weapons of a certain type to be treated as a different type. For example, the Viceroy, from the upcoming Dustgrave official adventure, allows Launchers to be treated as both Launchers and CQB weapons.

Describe the solution you'd like
Devise a way to leverage the Bonus system to add to (or potentially replace) a Weapon's type, once both the weapon and the bonus-granting item are equipped.

For example, using the Viceroy: The expected algorithm may be:

  1. Equip weapon
  2. During bonus checking, check for a "Weapon Type" bonus
  3. If the weapon matches the "Weapon Type" bonus, append the new weapon type to the weapon's types listed in the bonus (will require Weapon Type to be an array, which it is not as of v2.3.11)
  4. If the "Weapon Type" bonus is removed, all affected weapons are appropriately updated (basically, recalculate the weapon types again, which may already be covered with the existing Bonus logic)

Describe alternatives you've considered
A potential workaround feature would be #2180 for the case of Weapon Mods, though Synergies would still not work correctly.

Additional context
This is a refinement of #2132. This will likely require a solution for #1760 so that the weapon's data can maintain an Array of Weapon Types.

Given that there's other aspects of weapons and systems that could be potentially augmented in a similar fashion, I would say that this change should ideally be extensible to other kinds of changes (e.g. replacing Main with Heavy, etc.).

@msprijatelj msprijatelj added feature New feature or request help wanted Extra attention is needed labels Feb 1, 2023
@msprijatelj msprijatelj pinned this issue Feb 1, 2023
@theVJagrawal
Copy link

Hi @msprijatelj I can take up on this, can you assign this. I'm going to take up this as a part of my academics. It'd be helpful. Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants