Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch 8 compatibility #169

Open
hacfi opened this issue Jan 23, 2023 · 0 comments
Open

Elasticsearch 8 compatibility #169

hacfi opened this issue Jan 23, 2023 · 0 comments

Comments

@hacfi
Copy link

hacfi commented Jan 23, 2023

In version 8 of elasticsearch/elasticsearch the namespace changed from Elasticsearch to Elastic\Elasticsearch (https://github.com/elastic/elasticsearch-php/blob/main/BREAKING_CHANGES.md). Integrating this bundle into a Symfony 6 project I've noticed that there is no way to change massive_search.search.adapter.elastic.client.class (https://github.com/massiveart/MassiveSearchBundle/blob/2.8/Resources/config/adapter_elastic.xml#L7).

The issue is that in loads the adapter_elastic.xml before checking the existence of that class and loading the xml will always reset it:
https://github.com/massiveart/MassiveSearchBundle/blob/2.8/DependencyInjection/MassiveSearchExtension.php#L79-L81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hacfi