Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Fix {} keepalives #101

Open
codesections opened this issue Mar 20, 2020 · 0 comments
Open

Fix {} keepalives #101

codesections opened this issue Mar 20, 2020 · 0 comments
Labels
post-1.0 Feature to add after releasing v1.0.0

Comments

@codesections
Copy link
Contributor

Since #78, Flodgatt has sent an keepalive websocket message consisting of {} to inform the client that the connection is still alive. This is perfectly functional, but is slightly ugly when debugging: when looking at the message view of a websocket connection, the actual messages are mixed in with many pings as shown below

pings_000

This is not much of an issue, even when debugging: it only shows up when you've selected the message pane of the relevant websocket request. This means it doesn't clutter the console or interfere with debugging any non-flodgatt features. On the other hand, it will be nice to get rid of the clutter when we can.

Fortunately, the issue has been fixed upstream, in Warp 0.2.2. Unfortunately, we're still on the last 0.1.x build of warp. Once we upgrade and deal with breaking changes (#75), should be be able to solve this issue.

@codesections codesections added the post-1.0 Feature to add after releasing v1.0.0 label Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
post-1.0 Feature to add after releasing v1.0.0
Projects
None yet
Development

No branches or pull requests

1 participant