Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support StandardABM #13

Closed
mastrof opened this issue Mar 30, 2023 · 2 comments · Fixed by #17
Closed

Support StandardABM #13

mastrof opened this issue Mar 30, 2023 · 2 comments · Fixed by #17
Labels
breaking Breaking change enhancement New feature or request

Comments

@mastrof
Copy link
Owner

mastrof commented Mar 30, 2023 •
edited
Loading

By default MicrobeAgents now works with UnremovableABM; there should also be:

  • a constructor for StandardABM
  • an overload of run! for StandardABM
@mastrof mastrof added the enhancement New feature or request label Mar 30, 2023
@mastrof mastrof changed the title Add constructor for StandardABM Support StandardABM Apr 18, 2023
@mastrof
Copy link
Owner Author

mastrof commented Apr 18, 2023

I wonder whether the overloaded run! even makes sense. I can probably drop the overloading and just expect users to choose their stepping functions explicitly

@mastrof mastrof linked a pull request Apr 21, 2023 that will close this issue
Support both UnremovableABM and StandardABM #17
Merged
@mastrof mastrof added the breaking Breaking change label Apr 21, 2023
@mastrof
Copy link
Owner Author

mastrof commented Apr 21, 2023

run! will stay overloaded (although it will undergo changes in a different pr), but will work for all AgentBasedModel types. With #17 UnremovableABM won't be the default anymore. ABM type will have to be declared explicitly

@mastrof mastrof closed this as completed Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Breaking change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support both UnremovableABM and StandardABM mastrof/MicrobeAgents.jl
1 participant
@mastrof