Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retrieving suggestions from results #26

Closed
Radiergummi opened this issue Mar 29, 2021 · 0 comments
Closed

Support retrieving suggestions from results #26

Radiergummi opened this issue Mar 29, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Radiergummi
Copy link
Member

Currently, there is no way to access suggestions returned from the server. This is a huge feature of Elasticsearch and shouldn't be ignored.

There are multiple approaches possible:

  1. Implement a separate method for suggestions, something like $query->suggestions($conditions) which returns a special suggestion collection.
  2. Overload the Collection class to use dynamic response properties.
  3. Adding suggestion accessors to Collections.

For now, I'll implement variant 3 as it's the easiest. With the next major release, we'll probably adopt a more sophisticated approach.

@Radiergummi Radiergummi added the enhancement New feature or request label Mar 29, 2021
@Radiergummi Radiergummi self-assigned this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant